feat: Add Task Definition ARN Option #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzfuz
force-pushed
the
add-task-def-arn-option
branch
2 times, most recently
from
943f856
to
cb59e6a
Compare
muzfuz
changed the title
muzfuz
force-pushed
the
add-task-def-arn-option
branch
from
cb59e6a
to
33c55d7
Compare
muzfuz
commented
Jul 6, 2023
| 'task-definition': 'task-definition.json', | ||
| 'run-task': 'true', | ||
| }[input]; | ||
| }); |
There was a problem hiding this comment.
In case you're wondering what's going on here - I've removed jest "magic" and replaced it with an actual object that is easier to test against. Same in several other areas.
cuotos
approved these changes
Jul 6, 2023
muzfuz
added a commit
that referenced
this pull request
Jul 11, 2023
* Add task def arn options * Remove console.log * Additional debug logging * package
muzfuz
added a commit
that referenced
this pull request
Aug 4, 2023
* Add task def arn options * Remove console.log * Additional debug logging * package
muzfuz
added a commit
that referenced
this pull request
Aug 4, 2023
* Add task def arn options * Remove console.log * Additional debug logging * package
muzfuz
added a commit
that referenced
this pull request
Aug 4, 2023
* Add task def arn options * Remove console.log * Additional debug logging * package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to pass in a task definition ARN instead of a file. This way, an pre-existing and already deployed task definition can be used to run subsequent tasks.
Worth noting that if the task hasn't been registered yet then this can fail.