-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual Rewrite #5899
Merged
BluSunrize
merged 29 commits into
BluSunrize:1.20.4
from
voidsong-dragonfly:fix/manualrewrite
Apr 20, 2024
Merged
Manual Rewrite #5899
BluSunrize
merged 29 commits into
BluSunrize:1.20.4
from
voidsong-dragonfly:fix/manualrewrite
Apr 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First three categories are reorganized - All manual entries that did not correspond codeside are renamed to match ingame names - Manual is prepped to recieve more changes - First three category entries with minimal changes are respaced - Respacing means separating into easily-read paragraphs - Also means making things fit onto pages better on my monitor - I do not know how it will behave on other monitors - Overall manual should hopefuly be more intelligible once this is done
BluSunrize
requested changes
Apr 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recipe change and "Update" category should be addressed.
src/datagen/java/blusunrize/immersiveengineering/data/recipes/DecorationRecipes.java
Outdated
Show resolved
Hide resolved
src/main/resources/assets/immersiveengineering/manual/en_us/heavy_plated_shield.txt
Show resolved
Hide resolved
src/main/resources/assets/immersiveengineering/manual/en_us/kinetic_generators.txt
Outdated
Show resolved
Hide resolved
src/main/resources/assets/immersiveengineering/manual/en_us/storage_minecarts.txt
Show resolved
Hide resolved
Hell Yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a full rewrite of sections of the manual for both clearness and organization.
Minor changes are discussed in the discord, but major ones are below:
First, categories got reorganized to better let people find items. The new list of categories is below.
Multiple new pages have been added, including for minecarts, gunpowder barrels, and hempcrete.
Several pages have been factored out of others for better searchability, including strip curtains, feedthrough insulators, posts, transformers, and more.