-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul Mineral Veins #5902
Merged
Merged
Overhaul Mineral Veins #5902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/datagen/java/blusunrize/immersiveengineering/data/recipes/MiscRecipes.java
Show resolved
Hide resolved
src/datagen/java/blusunrize/immersiveengineering/data/recipes/MiscRecipes.java
Outdated
Show resolved
Hide resolved
malte0811
reviewed
Mar 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly small things that can be ignored, IMO the translation keys are the most important one.
src/api/java/blusunrize/immersiveengineering/api/excavator/ExcavatorHandler.java
Show resolved
Hide resolved
src/datagen/java/blusunrize/immersiveengineering/data/recipes/MiscRecipes.java
Outdated
Show resolved
Hide resolved
src/datagen/java/blusunrize/immersiveengineering/data/recipes/builder/MineralMixBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/blusunrize/immersiveengineering/client/IEManual.java
Outdated
Show resolved
Hide resolved
...n/java/blusunrize/immersiveengineering/common/crafting/serializers/MineralMixSerializer.java
Outdated
Show resolved
Hide resolved
BluSunrize
force-pushed
the
feature/mineral-vein-rebalance
branch
from
March 31, 2024 11:51
9df31ab
to
4c25c0a
Compare
Changes made according to your reviews! Anything else before I merge? |
malte0811
approved these changes
Mar 31, 2024
No changes to content
… ores and less sulfur
…m if present. Drop Cooperite as it was the old platinum vein
…resent. Drop Cassiterite as a result.
BluSunrize
force-pushed
the
feature/mineral-vein-rebalance
branch
from
April 1, 2024 08:50
4c25c0a
to
2f44dae
Compare
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
Minor changes:
Closes #5891