Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Mineral Veins #5902

Merged
merged 26 commits into from
Apr 1, 2024
Merged

Overhaul Mineral Veins #5902

merged 26 commits into from
Apr 1, 2024

Conversation

BluSunrize
Copy link
Owner

@BluSunrize BluSunrize commented Mar 29, 2024

Major changes:

  • Mineral veins now use biome tags as conditions, this replaces dimension keys and allows more precise filtering
  • New Vein: Banded Iron, a primary iron deposit because it's IE's most common resource
  • New Vein: Lazulitic Intrusion, comprised of lapis and gold, making it ideal for decoration and enchanting
  • New Vein: Alluvial Sift, only found in river biomes, this allows the excavator to mine for diamonds
  • New Vein: Rich Auricupride, only found in mesa biomes, high in gold and some copper
  • Changed Pentlandite to be primarily a nickel vein since its essential for IE's mid- and lategame architecture
  • Changed Wolframite to include tin when present

Minor changes:

  • Reduce overall sulfur output of veins
  • Changed a variety of other veins to prioritze secondary ores that IE relies on (lead, silver)
  • Changed weight and failchance on various veins, this makes "necessary" resources more common
  • Changed various veins to only show up in certain biomes, making "decorative" veins like Silt less common
  • Actually increased the weight of "rare" veins such as Beryl and Uraninite, because they are now limited by biome
  • Allow survey tools to be used on netherrack and soul sand, to make searching in the Nether viable

Closes #5891

@BluSunrize BluSunrize requested review from malte0811 and removed request for malte0811 March 29, 2024 20:46
Copy link
Collaborator

@malte0811 malte0811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small things that can be ignored, IMO the translation keys are the most important one.

@BluSunrize BluSunrize force-pushed the feature/mineral-vein-rebalance branch from 9df31ab to 4c25c0a Compare March 31, 2024 11:51
@BluSunrize
Copy link
Owner Author

Changes made according to your reviews!

Anything else before I merge?

@BluSunrize BluSunrize requested a review from malte0811 March 31, 2024 11:52
@BluSunrize BluSunrize force-pushed the feature/mineral-vein-rebalance branch from 4c25c0a to 2f44dae Compare April 1, 2024 08:50
@BluSunrize BluSunrize merged commit f49f7d5 into 1.20.4 Apr 1, 2024
4 checks passed
@BluSunrize BluSunrize deleted the feature/mineral-vein-rebalance branch June 14, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants