Remove CustomParticleManager #6079
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was used to fix a Vanilla bug where opaque particles could not show behind translucents. This has been fixed in NeoForge itself.
|
This should also reduce the number of draw calls for Immersive Engineering's block entities (since switching between particle types incurs a change in render layers, which flushes the current draw call.) And it will enable better compatibility with Sodium while allowing our optimizations to continue being applied (see #6078.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used to fix a Vanilla bug where opaque particles could not show behind translucents. This has been fixed in NeoForge itself.
This has not been fully tested, however it seems to work in both cases it is used.