Skip to content

Commit

Permalink
Remove py37, add py311, and fix Rectangle kwarg error (#1082)
Browse files Browse the repository at this point in the history
---------

Co-authored-by: Adrien Berchet <adrien.berchet@epfl.ch>
  • Loading branch information
eleftherioszisis and adrien-berchet authored Sep 15, 2023
1 parent 20bddc5 commit 8d856e5
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/run-tox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10']
python-version: ['3.8', '3.9', '3.10', '3.11']

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
Expand Down
8 changes: 4 additions & 4 deletions doc/source/developer.rst
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ individually:

.. code-block:: bash
$ tox -e py36-lint # runs only pylint
$ tox -e py36-docs # run only documentation check
$ tox -e py36 # run only the tests
$ tox -e py38-lint # runs only pylint
$ tox -e py38-docs # run only documentation check
$ tox -e py38 # run only the tests
You can also run tests manually via `pylint` but you need to make sure that you have installed
all required dependencies in your virtual environment:
Expand All @@ -81,4 +81,4 @@ Then, run the tests manually. For example,
Python compatibility
--------------------

We test the code against Python 3.6 and 3.7.
We test the code against Python 3.8, 3.9, 3.10, and 3.11.
2 changes: 1 addition & 1 deletion neurom/view/matplotlib_impl.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def _get_rectangle(x, y, linewidth):
return Rectangle(x - linewidth / 2. * np.array([-np.sin(angle), np.cos(angle)]),
np.linalg.norm(diff),
linewidth,
np.rad2deg(angle))
angle=np.rad2deg(angle))

segs = [_get_rectangle((seg[0][plane0], seg[0][plane1]),
(seg[1][plane0], seg[1][plane1]),
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,16 @@
],
},
include_package_data=True,
python_requires='>=3.7',
python_requires='>=3.8',
classifiers=[
'Development Status :: 6 - Mature',
'Intended Audience :: Education',
'Intended Audience :: Science/Research',
'Programming Language :: Python',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Topic :: Scientific/Engineering :: Bio-Informatics',
],
use_scm_version={"local_scheme": "no-local-version"},
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ testdeps =

[tox]
envlist =
py{37,38,39,310}
py{38,39,310,311}
py38-lint
py38-coverage
py38-docs
Expand Down Expand Up @@ -58,7 +58,7 @@ convention = google

[gh-actions]
python =
3.7: py37
3.8: py38
3.9: py39
3.10: py310
3.11: py311

0 comments on commit 8d856e5

Please sign in to comment.