Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional context to register/update operations #357

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ssssarah
Copy link
Contributor

@ssssarah ssssarah commented Nov 7, 2023

Goal: provide schema context when registering updating/schema to then avoid having as_jsonld expand the context into the schemas, and have the schemas have a link to their context rather than the whole context
https://bbpteam.epfl.ch/project/issues/browse/DKE-1249

Still in progress, to be tested

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9ffefac) 74.13% compared to head (9611c02) 74.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   74.13%   74.12%   -0.01%     
==========================================
  Files          93       93              
  Lines        5919     5921       +2     
==========================================
+ Hits         4388     4389       +1     
- Misses       1531     1532       +1     
Flag Coverage Δ
unittests 74.12% <72.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
kgforge/core/archetypes/store.py 59.36% <100.00%> (ø)
kgforge/specializations/stores/demo_store.py 39.41% <100.00%> (ø)
tests/specializations/stores/test_demo_store.py 100.00% <100.00%> (ø)
kgforge/core/forge.py 64.87% <66.66%> (+0.17%) ⬆️
kgforge/specializations/stores/bluebrain_nexus.py 28.57% <55.55%> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants