Add integration tests for automatic project deletion #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsdu
commented
Aug 4, 2023
| @@ -82,36 +82,42 @@ class AdminDsl(cl: HttpClient, config: TestsConfig) extends TestHelpers with Cir | |||
| id: String, | |||
| description: String, | |||
| authenticated: Authenticated, | |||
| expectedResponse: Option[ExpectedResponse] = None | |||
| expectedResponse: Option[ExpectedResponse] = None, | |||
| ignoreConflict: Boolean = false | |||
There was a problem hiding this comment.
To be able to run the test locally multiple times
shinyhappydan
requested changes
Aug 4, 2023
Comment on lines
28
to
38
| "Setting up" should { | ||
| "succeed in setting up org and project" in { | ||
| for { | ||
| _ <- aclDsl.addPermissions("/", Bojack, Set(Organizations.Create, Projects.Delete, Resources.Read, Events.Read)) | ||
| // First org and projects | ||
| _ <- adminDsl.createOrganization(org, org, Bojack, ignoreConflict = true) | ||
| _ <- adminDsl.createProject(org, proj1, kgDsl.projectJson(name = proj1), Bojack) | ||
| _ <- deltaClient.get[Json](s"/projects/$ref1", Bojack)(expect(StatusCodes.OK)) | ||
| } yield succeed | ||
| } | ||
| } |
There was a problem hiding this comment.
This should be beforeAll since it's setup
Comment on lines
11
to
18
| /** | ||
| * Test related to automatic project deletion Only checks that the project deletion has been triggered and that the | ||
| * project itself has been deleted. All the additional checks on the deletion of resources/views contained in this | ||
| * project are done in [[ProjectsDeletionSpec]] | ||
| * | ||
| * @see | ||
| * ProjectsDeletionSpec | ||
| */ |
There was a problem hiding this comment.
It's probably worth mentioning the configuration that this test relies on ("autodeletion" is in the configuration as an organisation which will auto delete projects after 5 seconds)
olivergrabinski
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3866