Migrate auth token code to cats effect #4318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyhappydan
force-pushed
the
download-bug-weird
branch
from
79ce9ae
to
f19222e
Compare
shinyhappydan
force-pushed
the
download-bug-weird
branch
from
f19222e
to
e76ce0a
Compare
| import ch.epfl.bluebrain.nexus.delta.sdk.auth.Credentials.ClientCredentials | ||
| import ch.epfl.bluebrain.nexus.delta.sdk.identities.ParsedToken | ||
| import ch.epfl.bluebrain.nexus.delta.sdk.identities.model.AuthToken | ||
| import monix.bio.UIO | ||
| import monix.bio |
There was a problem hiding this comment.
Can we get rid of monix here?
There was a problem hiding this comment.
Ah, I should have commented this: distage fromEffect does not seem to work with cats effect right now. I didn't want to investigate, since this was just something I was doing for myself and I didn't want to waste too much time on it
There was a problem hiding this comment.
It is configured to expected a Monix IO for now and I don't think we can mix both
dantb
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.