Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure no-cov is set for benchmarks #45

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 22, 2024

No description provided.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.40%. Comparing base (28f9fa5) to head (139a4c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   41.40%   41.40%           
=======================================
  Files           9        9           
  Lines         500      500           
  Branches       42       42           
=======================================
  Hits          207      207           
  Misses        293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 22, 2024

CodSpeed Performance Report

Merging #45 will improve performances by 55.76%

Comparing no_cov_benchmarks (139a4c2) with main (28f9fa5)

Summary

⚡ 1 improvements

Benchmarks breakdown

Benchmark main no_cov_benchmarks Change
test_scanner_async_on_advertisement 35.5 ms 22.8 ms +55.76%

@bdraco bdraco merged commit 96e70eb into main Dec 22, 2024
11 checks passed
@bdraco bdraco deleted the no_cov_benchmarks branch December 22, 2024 21:22
@bdraco
Copy link
Member Author

bdraco commented Dec 22, 2024

Looks like its almost all protobuf overhead so nothing we can really do to improve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant