Updated docs/docstrings #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klinga
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Good changes. I like your take on the docstring formatting and richer information.
Solid!
@charlottekostelic Would you be able to bring the coverage to 100%?
|
Added another test so coverage should be 100% now. |
charlottekostelic
added a commit
that referenced
this pull request
May 6, 2024
* updated black to 24.3.0 (#96) * Fixed inconsistency in timeout types/default values (#98) * fixed inconsistency in timeout default values * type fixes in WorldcatAccessToken * test refactor, fixed typos and timeout assignment * fixed timeout in Query, added file for live tests * added int type for oclcNumbers arg (#97) * Updated docs/docstrings (#100) * reformatted doc strings, updated documentation * updated dependencies, changelog * clean up of MetadataSession docstrings * moved release checklist to contributing page * added bib_get_current_oclc_number test * Added tutorials to docs (#102) * Added tutorial draft and updated mkdocs.yml * Updated Full MARC reocrds use case * Added holdings use case to tutorial * tutorial edits * updated tutorials * Updated tutorials * Simplified layout and made copy edits * Updated changelog * Updated OCLC Number prefix handling (#104) * changed oclc prefix handling, refactored tests * updated prefix handling section in docs * updated changelog and fixed type issue in utils.py * fixed oclc prefixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed:
Added:
ValueErroris raised if more than 10 OCLC Numbers are passed as an arg)