Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New endpoints #76

Closed
wants to merge 5 commits into from
Closed

New endpoints #76

wants to merge 5 commits into from

Conversation

charlottekostelic
Copy link
Contributor

@charlottekostelic charlottekostelic commented Feb 21, 2024

Added methods for new endpoints:

  • Methods with new functionality:
    • create_bib
    • get_bib_classification
    • get_bib_holdings
    • get_institution_holding_codes
    • match_bib
    • replace_bib
    • set_holding (sets a holding with MARC record)
    • unset_holding (unsets a holding with MARC record)
    • validate_bib
  • Methods for endpoints that correspond to previous functionality (old_method -> new_method)
    • search_current_control_numbers -> get_current_oclc_numbers
    • holding_get_status -> get_institution_holdings
    • search_general_holdings -> search_bib_holdings
    • search_brief_bib_other_editions -> search_brief_bibs_other_editions
    • holding_set -> set_holding_oclc_number
    • holding_unset -> unset_holding_oclc_number

Added W503 (line break before binary operator) to flake8 per-file-ignores for tests

Changed existing methods based on new endpoints and parameters:

  • search_brief_bibs: added new args
  • search_shared_print_holdings: removed offset and limit from args based on change to endpoint
  • get_full_bib: changed options for responseFormats based on change to endpoint

Changed args for MetadataSession methods to camelCase

Removed handling of 409 error from Query class

Breakdown of new endpoints, new methods, and equivalent methods in 0.5.0 in spreadsheet here:
https://docs.google.com/spreadsheets/d/1K24N3JiR762g0OrGUOdF10eT_gXLsH9l4yt4AiyWjfc/edit?usp=sharing

@charlottekostelic charlottekostelic marked this pull request as draft February 21, 2024 23:13
@charlottekostelic
Copy link
Contributor Author

I'm going to close this and break it into smaller PRs.

@charlottekostelic charlottekostelic deleted the new-endpoints branch February 28, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant