Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

API Dependencies #52

Merged
merged 7 commits into from
Jan 25, 2024
Merged

API Dependencies #52

merged 7 commits into from
Jan 25, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Jan 22, 2024

This allows APIs to specify dependencies on other APIs that they rely on. It is checked at runtime when debug mode is enabled when the run button is pressed.

This also completely removes the LinearAPI class. The normal API class now supports accessing the LinearOpMode as long as isLinear is set to true.

Now, linear APIs will inherit the normal API class but will set isLinear to true. They can then access the linearOpMode property like normal.
@BD103 BD103 added feature New feature or request breaking A major change that affects many other things labels Jan 22, 2024
@BD103 BD103 added this to the Panther Power Qualifier milestone Jan 22, 2024
@BD103 BD103 self-assigned this Jan 22, 2024
@BD103 BD103 marked this pull request as ready for review January 22, 2024 20:27
@BD103 BD103 mentioned this pull request Jan 22, 2024
9 tasks
Copy link
Contributor

@cadenceforney cadenceforney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and I enjoy object APIDependencies : OpModeManagerNotifier.Notifications {

@BD103
Copy link
Member Author

BD103 commented Jan 23, 2024

looks good and I enjoy object APIDependencies : OpModeManagerNotifier.Notifications {

Awesome! I'll test it Wednesday and merge it then. (Likely after I merge #51.)

OpModeManagerNotifier.Notifications is great because it lets us run code immediately when the Init, Run, and Stop buttons are pressed, even before the opmode receives the update. It's what I used to remove Reset.init(this) too.

@BD103
Copy link
Member Author

BD103 commented Jan 25, 2024

I did some testing, and it all seemed to work! Merging :)

@BD103 BD103 merged commit 4a6ffb0 into main Jan 25, 2024
2 checks passed
@BD103 BD103 deleted the api-deps branch January 25, 2024 01:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking A major change that affects many other things feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants