Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add resuming download feature for LCSC database #556

Merged
merged 5 commits into from
Dec 13, 2024
Merged

[feat] Add resuming download feature for LCSC database #556

merged 5 commits into from
Dec 13, 2024

Conversation

Oliver0804
Copy link
Contributor

@Oliver0804
[feat] Add resuming download feature for LCSC database
c96b587 
- Implemented the feature to resume downloading the LCSC database to handle interrupted downloads
- Referenced Issue Bouni#536 and completed the required implementation
@Oliver0804 Oliver0804 mentioned this pull request Dec 4, 2024
Closed
@Oliver0804
Copy link
Contributor Author

Thank you for your correction! I was just about to start, and you already fixed it—haha!

@Bouni
Copy link
Owner

Bouni commented Dec 13, 2024

No problem 😅

I test your PR right now. It seems to work as expected, but the progress bar is no longer working.
Would you mind take a look at that?

@Oliver0804
Copy link
Contributor Author

ok!let me check where the code went wrong.

@Bouni
Copy link
Owner

Bouni commented Dec 13, 2024

I had a look and it was just two lines you removed, probably by accident.
To speed things up, I re-added them for you.

@Bouni Bouni merged commit 0cc3f10 into Bouni:main Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oliver0804 @Bouni