Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 126 fix albam version in error report #127

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

Brachi
Copy link
Owner

@Brachi Brachi commented Sep 7, 2024

Fixes #126
Include correct version in error report (right now that would be 0.4.0.dev11) and redact user home.
Also say how to read the console in unexpected errors.

@Brachi
Copy link
Owner Author

Brachi commented Sep 7, 2024

@HenryOfCarim could you please test that the user home is redacted in Windows?

@HenryOfCarim
Copy link
Collaborator

@Brachi Well, the result is strange, it doesn't show the report as it did before, in the console for errors like this
image
For other errors it shows the trace with the username

  File "C:\Users\myname\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\albam\vfs.py", line 270, in execute
    w.write(vfile.get_bytes())
  File "C:\Users\myname\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\albam\vfs.py", line 67, in get_bytes
    accessor = self.get_accessor()
  File "C:\Users\myname\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\albam\vfs.py", line 76, in get_accessor
    root = vfs.file_list[self.tree_node.root_id]
KeyError: 'bpy_prop_collection[key]: key "" not found'```

@Brachi Brachi force-pushed the GH-126-fix-albam-version-in-error-report branch from 8bd4fa8 to 522b593 Compare September 7, 2024 17:22
@Brachi
Copy link
Owner Author

Brachi commented Sep 7, 2024

@HenryOfCarim Can you try to force an unexpected error message and check the traceback in the console?

Per #118 , you can force by simply removing a material and then exporting.

For other errors it shows the trace with the username

Is this from an unexpected error as well? or a "check" that failed?

@HenryOfCarim
Copy link
Collaborator

@Brachi For this error it worked as expected
image

@Brachi Brachi merged commit ba238b9 into main Sep 7, 2024
3 checks passed
@Brachi Brachi deleted the GH-126-fix-albam-version-in-error-report branch September 28, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong version in error report
2 participants