Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace handrolled html+js by React #19

Merged
merged 93 commits into from
Jan 25, 2024
Merged

Replace handrolled html+js by React #19

merged 93 commits into from
Jan 25, 2024

Conversation

BrechtSerckx
Copy link
Owner

@BrechtSerckx BrechtSerckx commented Jan 2, 2023

The handrolled HTML and Javascript was difficult to extend. It is well possible that #18 is caused by a bug there.
This PR re-implements the UI using ReactJS.
The goal is to have the exact same UI, but much more maintainable code.
A next PR can then improve the UI to fix #3.

TODOS:

  • nix derivation for react
  • ci for react
  • docker image
  • better way of serving the react part / including the build dir

FUTURE:

  • generate api from servant
  • stackProject
  • use single nixpkgs

@BrechtSerckx BrechtSerckx added the enhancement New feature or request label Jan 2, 2023
@BrechtSerckx BrechtSerckx force-pushed the react branch 2 times, most recently from 1085a62 to 2c475b4 Compare May 9, 2023 20:17
@BrechtSerckx BrechtSerckx force-pushed the react branch 3 times, most recently from c88885d to b68c81e Compare May 18, 2023 09:03
@BrechtSerckx BrechtSerckx marked this pull request as ready for review May 18, 2023 09:45
@BrechtSerckx BrechtSerckx merged commit a08f56b into master Jan 25, 2024
2 checks passed
@BrechtSerckx BrechtSerckx deleted the react branch January 25, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UI
1 participant