Python module refactor #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kavitharaju
commented
Aug 9, 2022
kavitharaju
commented
- Uses python 3.10 and match-case Use python 3.10 #154
- Changes the API names as per discussion here API names in python and javascript #155 and update the API guide jupyter notebook accordingly
- Uses the lxml library instead of the python's standard xml library Use lxml library instead of xml in python module #156
- Enum Format.ST = "syntax-tree" - Class data member USFMParser.syntax_tree - Class data member USFMParser.USFM_bytes - Class member function USFMParser.to_syntax_tree() - Class member function USFMParser.to_dict() - Class member function USFMParser.to_list() - Class member function USFMParser.to_markdown() - Class member function USFMParser.to_usx()
joelthe1
reviewed
Aug 10, 2022
| @@ -1,2 +1,4 @@ | |||
| tree-sitter==0.20.0 | |||
| jupyterlab==3.3.2 | |||
| jupyterlab==3.4.4 | |||
There was a problem hiding this comment.
I think this is okay for now. But maybe you should move jupyterlab to a dev-requirements.txt file so that it doesn't get mixed up with the actual package dependencies.
There was a problem hiding this comment.
I am looking into how python modules are packaged for publishing on pypi. I think this file is not used there. But I shall make changes if required to separate it as dev dependency in a later PR
joelthe1
reviewed
Aug 10, 2022
python-usfm-parser/usfm_grammar.py
Outdated
| def __init__(self, usfm_string): | ||
| # super(USFMParser, self).__init__() | ||
| self.USFM = usfm_string | ||
| self.USFMbytes = None | ||
| self.AST = None | ||
| self.USFM_bytes = None |
There was a problem hiding this comment.
I think we should keep all the attribute names in lowercase for consistency sake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.