S3Upload UI fixes

[deanhannigan]

Description

A couple of minor fixes for the S3Upload component for issues that I came across while testing.

Addresses

• Fix - When making a put request to S3, the response body is empty. When the api client encountered this, the call to reponse.json() was triggering an error. Instead a call to .text() is made and verified. If the response text is empty, an empty object is returned instead.
• If you moved the S3Upload component in the builder the progress circle would appear and remain visible
• Minor change to allow binding of the S3Upload picker value within its own settings. This is specifically useful if you want to map the name of a file you've added in file picker directly to the File name setting.
  • Using the existing notation will now output the file name {{ My File Upload.Value.0.name }}
  • This will output the browser mimetype {{ My File Upload.Value.0.type }}

Screenshots

Original S3 issue. This is now prevented

Launchcontrol

Minor fix for S3Upload component and added nested prop binding.

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[aptkingston]

LGTM but one small change needed to allow all normal bindings to work.

[aptkingston]

This means the only context available is itself, but we need to add the normal context in here too don't we? Since you have access to all normal bindings when configuring this setting in the builder.

So we just need to pull in normal context as well:

const context = getContext("context")
...
const processedFileKey = processStringSync(key, {
  ...$context,
  [$component.id]: fieldState,
})

[deanhannigan]

Yep, that's correct, the other context elements should be present. $context also contains the correct parameter so there's no need for the [$component.id] entry now. Cheers!