fix: make action standalone #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC'ing @nat-goodspeed, I don't think this will cause any issues in your pipeline, but just wanted to make you aware of this change 🙂. See #97 for more info. |
daveplunkett
approved these changes
Feb 27, 2024
|
Thank you. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had initially taken out the setup-node step in fear that it might interfere with the setup-node step of the calling action. This doesn't appear to be an issue after all.
Additionally, by including a setup-node step, the calling action doesn't have to worry about calling setup-node, which is a better solution for actions that otherwise wouldn't use node.
Finally, for actions already using node, we expose a
node-versioninput so that the calling action can dictate which version of node symbol-upload uses.Fixes #97