chore: fix unit tests #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveplunkett
approved these changes
Jun 13, 2024
bobbyg603
added a commit
that referenced
this pull request
Jun 13, 2024
bobbyg603
added a commit
that referenced
this pull request
Jun 14, 2024
* fix: readable stream locked on retry * chore: create new readstream when retrying * fix: don't allow extra concurrency in worker pool * fix: use availableParallelism instead of cpus to support taskset * fix: worker pool maxWorkers * chore: fix unit tests (#121) * chore: update packages * fix: destroy zip output file stream * chore: fix lint * fix: revert back to cpus to satisfy node 18.5 * fix: don't fire uploads promises all at once (#123) * fix: await worker promises instead of firing them all off * fix: max workers should be cpus minus one for main thread * fix: don't retry max size exceeded errors * fix: readable stream locked * fix: update @bugsplat/js-api-client * fix: make error message last log statement * fix: use path as tempSubdir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test runs so fast the time ends up being 0 causing prettyBytes to fail because anything divided by 0 is NaN.
Checklist