-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRIPT Python SDK 2.0 First Release #272
Conversation
* added CRIPT logo * updated python badge to python 3.7 instead of python 3.9 * added a section that "we invite contribution"
ignoring common files and directories that are unneeded
Create .gitignore
updated read me
issue templates
added mypy cache to be ignored
brought it over from the old sdk docs
Create pull_request_template.md
Update .gitignore
created setup.py and setup.cfg
moved pyproject.toml from src/ to the project root directory
* file.py * group.py * user.py
…d more self documenting
* changed conftest.py to get storage token from env variable * updated CI to have `CRIPT_STORAGE_TOKEN` * updated CI to have `CRIPT_STORAGE_TOKEN`
* wrote docs for `load_nodes_from_json` * update docs for `load_nodes_from_json` * added type hinting to `load_nodes_from_json` * update `load_nodes_from_json` function to work correctly without errors * updated docs fore `load_from_json` return type * updated docs fore `load_from_json` return type * optimized imports
* added documentation for `_NodeDecoderHook` * fixed `_NodeDecoderHook` `def __init__()` notes * fixed `_NodeDecoderHook` `def __call__()` returns documentation
* simplified tests and got rid of `deep_copy` * optimized imports * passed tests
adding `None` in header escapes the html and looks weird on the right side navigation
* updated tests for staging * trunk spelling --------- Co-authored-by: Ludwig Schneider <ludwigschneider@uchicago.edu>
* wrote documentation for `NodeEncoder` * updated documentation for `NodeEncoder` * updated documentation for `NodeEncoder` * formatted with black * added typing for mypy * formatted with trunk * ignoring mypy static type error * updated documentation return type * formatted with black * adjust type description for condense_uuid --------- Co-authored-by: Ludwig Schneider <ludwigschneider@uchicago.edu>
* add default args to JSON if not present * fix collection integration, by surpressing the right default args in JSON * trunk fixes * found some more * adjust tests * missing test fix
* change the representation of UID * fix the two tests that were missing * this should work now * missing test fix * conftest get integration test var from env var with exception handling (#253) * updated CI to have `CRIPT_STORAGE_TOKEN` * if no env var then integration tests are true * pass empty identifier list too * uuidfy experiment/data * thx mypy --------- Co-authored-by: nh916 <navidhariri25@gmail.com>
doing this last second
doing this last second
doing this last second
Merging to
|
I'm following the instructions from https://c-accel-cript.github.io/Python-SDK/tutorial/cript_installation_guide/ Installing the package like that: Win11, Python 3.10.6 Install went well. Now following https://c-accel-cript.github.io/Python-SDK/tutorial/how_to_get_api_token/ Not clear where I should paste my tokens, but I assume I need to create a *.py script file. Now following https://c-accel-cript.github.io/Python-SDK/examples/synthesis/ I successfully setup my script to create a new project
I copy/pasted all the instructions, the project was generated but rejected by the server because of duplicates. My project name was changed, but I assume there are duplicates in the materials (maybe on experiments too). Not easy to guess which node has a duplicate name, I assume this will happend to every user trying this. The log looks like:
I suggest to define a global a prefix (or suffix) by doing let's say: ...or to display the list of duplicates. My bad, I added two identical Experiments, I figured it out when adding a prefix manually replacing FName are fixed, but I got now an error regarding MaterialPost additionalProperties:
I assume there is a typo in the documentation, and pubchem_cid should have been defined instead of pubchem_id. Retrying... I assumed well, no more issue with pubchem_id. But, I got another issue:
Apparently the name is missing on the material. After searching for To be continued... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why, but I couldn't finish the walkthrough: https://c-accel-cript.github.io/Python-SDK/examples/synthesis/
The last error I got was not related to my data I think. It's like a node with a uuid was trying to be posted without a name. See my comments above this.
Yes, this is a confusing data error. |
No description provided.