Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cognito Tokens using SecretsManager #452

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

izaim
Copy link
Collaborator

@izaim izaim commented Apr 2, 2024

Changes

Fixed CI

@izaim izaim requested a review from brili April 2, 2024 23:11
Copy link

trunk-io bot commented Apr 2, 2024

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@izaim izaim requested a review from InnocentBug April 8, 2024 21:44
Copy link
Collaborator

@InnocentBug InnocentBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I won't approve for merge, since there are some other parts, I want this in too.
And I want to merge this after save and search work, so tests continue to be green.

@@ -1,7 +1,7 @@
# CRIPT DEVELOPMENT TEAM

- [Navid Hariri](https://github.com/nh916)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navid did contribute, any reason we should remove him?

@@ -23,20 +24,18 @@ concurrency:
# Cancel in-progress runs when a new workflow with the same group name is triggered
cancel-in-progress: true

env:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants