Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search, so it works with the new after syntax. #456

Merged
merged 10 commits into from
May 17, 2024

Conversation

InnocentBug
Copy link
Collaborator

Description

Updated search URL generation.
It now works with

Changes

Some updates to the paginator interface that enables partial searches, that allows interrupted searches for the SDK as well.

Known Issues

Many entries on stage are invalid.
So we had to work around this in the tests.
Ideally we don't have to do that.

@brili
I noticed, that BigSMILES search does not deliver 10 nodes by default. It is 1 node for me.

@brili
Also it appears that the after method returns some nodes multiple times.
I get the same UUID in the search results, I don't think that is as it should be.

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.
  • My code changes have been verified by automated tests and pass all relevant test scenarios.

Copy link

trunk-io bot commented May 14, 2024

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@InnocentBug InnocentBug self-assigned this May 14, 2024
@InnocentBug InnocentBug requested a review from brili May 14, 2024 20:16
brili
brili previously approved these changes May 16, 2024
@InnocentBug InnocentBug requested a review from brili May 16, 2024 20:47
@brili
Copy link
Member

brili commented May 17, 2024

@InnocentBug thanks for pointing out the dupes issue, its an easy fix.

@InnocentBug InnocentBug merged commit dd4004f into develop May 17, 2024
13 checks passed
@InnocentBug InnocentBug deleted the search-after branch May 17, 2024 12:28
InnocentBug added a commit that referenced this pull request May 20, 2024
* Update to 1.0.1

* update python version

* run new version on  3.10

* revamp search

* remove explicit model version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants