Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.4.0 #457

Merged
merged 5 commits into from
May 20, 2024
Merged

Release 2.4.0 #457

merged 5 commits into from
May 20, 2024

Conversation

InnocentBug
Copy link
Collaborator

Version 2.4.0

New Features

  • cript.API searches work as intended.
  • SDK initiated searches can be controlled and interrupted for large queries.

Known Issues and Bugs

  • Saving projects is not supported. Temporarily, you can use get_expanded_json to store a JSON representation of projects, which can be uploaded into CRIPT at a later time.
  • Permission settings in CRIPT do not influence the behavior of the SDK objects.
  • Tests that require valid tokens (like saving or searching) are not included in CI/CD tests.
  • BigSMILES searches can contain duplicates.

Bug Fixes

  • Search is now matched with the API requirements.

Breaking Changes

  • The Paginator interface changed to reflect the backend requirements.

Health Report

=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.11.2, pytest-7.4.3, pluggy-1.3.0
rootdir: /home/ludwig/git/Python-SDK
plugins: cov-4.1.0
collected 124 items

tests/test_node_util.py ...........                                                                                                                                                                         [  8%]
tests/api/test_api.py .....                                                                                                                                                                                 [ 12%]
tests/api/test_db_schema.py .....                                                                                                                                                                           [ 16%]
tests/api/test_search.py .....F                                                                                                                                                                             [ 21%]
tests/nodes/test_utils.py ..                                                                                                                                                                                [ 23%]
tests/nodes/primary_nodes/test_collection.py .....F                                                                                                                                                         [ 28%]
tests/nodes/primary_nodes/test_computation.py .....F                                                                                                                                                        [ 33%]
tests/nodes/primary_nodes/test_computational_process.py ....F                                                                                                                                               [ 37%]
tests/nodes/primary_nodes/test_data.py ....F                                                                                                                                                                [ 41%]
tests/nodes/primary_nodes/test_experiment.py ....F                                                                                                                                                          [ 45%]
tests/nodes/primary_nodes/test_inventory.py ..F                                                                                                                                                             [ 47%]
tests/nodes/primary_nodes/test_material.py ...F                                                                                                                                                             [ 50%]
tests/nodes/primary_nodes/test_process.py .....F                                                                                                                                                            [ 55%]
tests/nodes/primary_nodes/test_project.py ...F                                                                                                                                                              [ 58%]
tests/nodes/primary_nodes/test_reference.py ......F                                                                                                                                                         [ 64%]
tests/nodes/subobjects/test_algorithm.py ..F                                                                                                                                                                [ 66%]
tests/nodes/subobjects/test_citation.py ..F                                                                                                                                                                 [ 69%]
tests/nodes/subobjects/test_computational_forcefield.py ..F                                                                                                                                                 [ 71%]
tests/nodes/subobjects/test_condition.py ..F                                                                                                                                                                [ 74%]
tests/nodes/subobjects/test_equipment.py ..F                                                                                                                                                                [ 76%]
tests/nodes/subobjects/test_ingredient.py ..F                                                                                                                                                               [ 79%]
tests/nodes/subobjects/test_parameter.py ..F                                                                                                                                                                [ 81%]
tests/nodes/subobjects/test_property.py ..F                                                                                                                                                                 [ 83%]
tests/nodes/subobjects/test_quantity.py ..F                                                                                                                                                                 [ 86%]
tests/nodes/subobjects/test_software.py ...F                                                                                                                                                                [ 89%]
tests/nodes/subobjects/test_software_configuration.py ..F                                                                                                                                                   [ 91%]
tests/nodes/supporting_nodes/test_file.py ..s....F                                                                                                                                                          [ 98%]
tests/nodes/supporting_nodes/test_user.py ..

FAILED tests/nodes/primary_nodes/test_collection.py::test_integration_collection - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/primary_nodes/test_computation.py::test_integration_computation - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/primary_nodes/test_computational_process.py::test_integration_computational_process - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/primary_nodes/test_data.py::test_integration_data - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/primary_nodes/test_experiment.py::test_integration_experiment - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/primary_nodes/test_inventory.py::test_integration_inventory - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/primary_nodes/test_material.py::test_integration_material - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/primary_nodes/test_process.py::test_integration_complex_process - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/primary_nodes/test_project.py::test_integration_project - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/primary_nodes/test_reference.py::test_integration_reference - IndexError: list index out of range
FAILED tests/nodes/subobjects/test_algorithm.py::test_integration_algorithm - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/subobjects/test_citation.py::test_integration_citation - IndexError: list index out of range
FAILED tests/nodes/subobjects/test_computational_forcefield.py::test_integration_computational_forcefield - AttributeError: 'NoneType' object has no attribute 'description'
FAILED tests/nodes/subobjects/test_condition.py::test_integration_process_condition - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/subobjects/test_equipment.py::test_integration_equipment - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/subobjects/test_ingredient.py::test_integration_ingredient - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/subobjects/test_parameter.py::test_integration_parameter - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/subobjects/test_property.py::test_integration_material_property - IndexError: list index out of range
FAILED tests/nodes/subobjects/test_quantity.py::test_integration_quantity - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/subobjects/test_software.py::test_integration_software - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/subobjects/test_software_configuration.py::test_integration_software_configuration - AttributeError: 'list' object has no attribute 'startswith'
FAILED tests/nodes/supporting_nodes/test_file.py::test_integration_file - AttributeError: 'list' object has no attribute 'startswith'
======================================================================== 22 failed, 101 passed, 1 skipped, 1 warning in 1506.18s (0:25:06) ========================================================================

* Update to 1.0.1

* update python version

* run new version on  3.10

* revamp search

* remove explicit model version
@InnocentBug InnocentBug requested a review from Ardi028 May 20, 2024 16:52
@InnocentBug InnocentBug self-assigned this May 20, 2024
Copy link

trunk-io bot commented May 20, 2024

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@InnocentBug InnocentBug merged commit cf7f6b0 into main May 20, 2024
11 checks passed
@InnocentBug InnocentBug deleted the release-2.4.0 branch May 20, 2024 20:49
@InnocentBug InnocentBug restored the release-2.4.0 branch May 20, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants