Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added module tab back to deviceview #123

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

nimrof
Copy link
Collaborator

@nimrof nimrof commented Jul 16, 2024

Think i reverted everything done here (43592ba), but not sure how it should work :(.
Can you help @trojanobelix

@nimrof nimrof self-assigned this Jul 16, 2024
@nimrof nimrof requested a review from trojanobelix July 16, 2024 20:30
@nimrof
Copy link
Collaborator Author

nimrof commented Jul 16, 2024

Think it is needed to fix this: #69

@trojanobelix
Copy link
Collaborator

Think you are right

CiA Draft Standard Proposal 306:
"If several modules are gathered to form a new Sub-Index, then the number is 0, followed by semicolon and the
number of bits that are created per module to build a new Sub-Index"

This feature is not implemented yet, and the parser will crash if something like Count=0;4 occurs.

Example from WI133489V1_25.eds:

[M1SubExt6000]
ParameterName=ReadInput8Bit
ObjectType=0x7
DataType=0x0005
AccessType=ro
PDOMapping=1
Count=0;4

@CANopenNode
Copy link
Owner

I tried to open that eds file from Weidmuller. File is opened without problems, modules are listed "Modues" tab. Information are just listed there, I didn't find any commands to interact with modules in GUI. I wasn't able to crash the program.

"Object Dictionary" tab does not show objects from any module, so it seems something is not yet implemented.

Some more tests:
Added this into eds file and open it (after [SupportedModules]):

[ConnectedModules]
NrOfEntries=3
1=2
2=2
3=4

showed a warning, but program didn't crash (correct behavior):

System.ArgumentException: An item with the same key has already been added.
   at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   at libEDSsharp.ConnectedModules..ctor(Dictionary`2 section) in Z:\CANopen\CANopenEditor\libEDSsharp\CanOpenEDS.cs:line 308
   at libEDSsharp.EDSsharp.Loadfile(String filename) in Z:\CANopen\CANopenEditor\libEDSsharp\CanOpenEDS.cs:line 951
   at ODEditor.ODEditor_MainForm.openEDSfile(String path, Filetype ft) in Z:\CANopen\CANopenEditor\EDSEditorGUI\Form1.cs:line 193

Next test, added this into eds file:

[ConnectedModules]
NrOfEntries=1
1=1

Opens correctly, list of modules is nicely colored, there is still no object 0x6000 in "Object Dictionary" tab.

Anyway, I think, it is safe to merge this PR for now.

@nimrof nimrof merged commit 18610b3 into main Aug 3, 2024
4 checks passed
@CANopenNode CANopenNode deleted the added-moduleInfo-tab-back-to-DeviceView branch August 6, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants