Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Extended operation no_op by parameter memory_alloc for container #1040

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Extended operation no_op by parameter memory_alloc for container #1040

merged 2 commits into from
Dec 5, 2022

Conversation

forman
Copy link
Member

@forman forman commented Dec 5, 2022

Addresses #980

@forman forman requested a review from TonioF December 5, 2022 13:19
TonioF
TonioF suggested changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@TonioF TonioF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The memory is not allocated in each step, only once. Either adjust the parameter description or move the memory.append()-line into the for loop.

@forman forman requested a review from TonioF December 5, 2022 15:28
@forman forman merged commit f522da9 into master Dec 5, 2022
@forman forman deleted the forman-980-no_op_with_memory_alloc branch March 25, 2023 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TonioF TonioF TonioF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forman @TonioF