Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated syntax for future rstan compatibility #158

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

andrjohns
Copy link

Now that rstan 2.26 is available on CRAN we need to update the deprecated syntax in your package's Stan models, otherwise it will fail to install with an upcoming version of RStan.

I've also updated the package structure to use the newer rstantools structure, this is needed to allow for rstantools to provide updates to Makevars{.win} files for compatibility with changes to rstan/StanHeaders

The following updates have been made:

  • New array syntax
  • fabs replaced by abs
  • lba_cdf renamed to lba_cdf_fun
    • Newer versions of Stan will require that functions ending in _cdf use the conditional | notation, but the current rstan has a bug and does not recognise it as valid. So by renaming we can satisfy both versions and easily revert the naming later

More information about the deprecated and removed syntax in Stan can be found here:

If you could merge and submit to CRAN soon, it would be greatly appreciated.

Let me know if you have any questions about these changes.

Thanks!

@andrjohns
Copy link
Author

@CCS-Lab would it be possible to push these changes to CRAN soon? Otherwise your package will break with the next rstan version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant