Update deprecated syntax for future rstan compatibility #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that rstan 2.26 is available on CRAN we need to update the deprecated syntax in your package's Stan models, otherwise it will fail to install with an upcoming version of RStan.
I've also updated the package structure to use the newer
rstantools
structure, this is needed to allow forrstantools
to provide updates toMakevars{.win}
files for compatibility with changes to rstan/StanHeadersThe following updates have been made:
fabs
replaced byabs
lba_cdf
renamed tolba_cdf_fun
_cdf
use the conditional|
notation, but the currentrstan
has a bug and does not recognise it as valid. So by renaming we can satisfy both versions and easily revert the naming laterMore information about the deprecated and removed syntax in Stan can be found here:
If you could merge and submit to CRAN soon, it would be greatly appreciated.
Let me know if you have any questions about these changes.
Thanks!