Skip to content

Commit

Permalink
Fixes for bugs related to SDOE in 3.21-rc (#1210)
Browse files Browse the repository at this point in the history
* restricting matplotlib due to issues when using 3.8

* cast parameter for setValue to int

* Add link to #1211

---------

Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
  • Loading branch information
kbuma and lbianchi-lbl authored Mar 27, 2024
1 parent 1161d04 commit 47053af
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion foqus_lib/gui/sdoe/sdoeAnalysisDialog.py
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ def runSdoeNUSF(self):
"mwr = %d, n = %d" % (mwr, results[mwr]["num_restarts"])
)
count += 1
self.SDOE2_progressBar.setValue((100 / len(mwr_list)) * count)
self.SDOE2_progressBar.setValue(int((100 / len(mwr_list)) * count))
QApplication.processEvents()

self.unfreeze()
Expand Down
4 changes: 3 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@
"cma",
"dask[dataframe,distributed]", # <2024.3",
# prebuilt wheels not available on 3.11 for matplotlib<3.6 on: macos arm64, win32
"matplotlib==3.*",
# matplotlib>=3.8 has API incompatibilities with SDoE plots
# see CCSI-Toolset/FOQUS#1211 for more information
"matplotlib >= 3.6.0, <= 3.7.5",
"python-tsp==0.3.1",
"mplcursors",
"numpy",
Expand Down

0 comments on commit 47053af

Please sign in to comment.