Limiting design size maximum

[sotorrio1]

Fixes/Addresses:

It address issue #1240

Summary/Motivation:

The spin boxes to set the design size in the SDoE Analysis Dialog (for either USF, NUSF or IRSF) should be set to a maximum of the size of the candidate set minus one to avoid issues with the SDoE algorithm.

Changes proposed in this PR:

• Previously design size was set to a maximum equal to the candidate set size.
• Now design size will be set to a maximum that is equal to the candidate set size minus one.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

[sotorrio1]

@bpaul4 I knew there was a check somewhere in the code, problem was that it was set to a maximum equal to the candidate set size. Now I'm limiting the maximum to candidate set size minus 1.

Let me know if this works for you (you shouldn't be able to set your design size to the same number as the candidate set size).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.78%. Comparing base (2e54f98) to head (5edc9da).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1244      +/-   ##
==========================================
+ Coverage   38.75%   38.78%   +0.02%     
==========================================
  Files         164      164              
  Lines       37139    37139              
  Branches     6164     6164              
==========================================
+ Hits        14392    14403      +11     
+ Misses      21611    21597      -14     
- Partials     1136     1139       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bpaul4]

It works perfectly! Thanks for making this change.