Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature [DEV-9186] -Symbol line charts #1817

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Conversation

Atash3000
Copy link
Collaborator

[Replace With Ticket Number]

Testing Steps

  1. Open Line Charts
  2. Visual Panel
Screenshot 2025-01-07 at 13 24 31 Screenshot 2025-01-07 at 13 24 09new dropdown "Line Datapoint Symbols" with options: None: No new shapes are added to line points, only the standard old circles are shown. Standard: Adds shapes (Circle, Square, Triangle, Diamond, Inverted Triangle) to line points, up to 5 shapes. For more than 5 series, additional series do not display shapes. 3. Legend Panel Select Legend Style: Lines. Enable the "Shapes" checkbox to add matching shapes to the legend lines.

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@Atash3000 Atash3000 added this to the 4.25.1 milestone Jan 7, 2025
@Atash3000 Atash3000 requested review from adamdoe and joshlacey January 7, 2025 18:58
@Atash3000 Atash3000 changed the title Feature/dev 9186 Feature [DEV-9186] -Symbol line charts Jan 7, 2025
</Tooltip.Target>
<Tooltip.Content>
<p>
Shapes will display in order circle, square, triangle, diamond, inverted triangle. Use with no
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might read better:

Shapes will appear in the following order: circle, square, triangle, diamond, and inverted triangle. Use with a maximum of 5 data points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants