FIX: Feature-[DEV-10046] : Dashboard Filters - Parent #1820
+635
−4,608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Atash3000 - It looks like there are failing unit tests on this PR. |
|
@adamdoe updated unit test. Should be good now. |
adamdoe
requested changes
Jan 15, 2025
| import _ from 'lodash' | ||
|
|
||
| export const updateChildFilters = (newSharedFilters: SharedFilter[], data: Record<string, any>): SharedFilter[] => { | ||
| const dateSet = Object.values(data).flat() |
|
|
||
| if (parentFilter) { | ||
| // Filter dataset based on parent's active value | ||
| const parentActiveValuesArr = dateSet.filter( |
|
@Atash3000 The parent filter selector should be a multi select. |
joshlacey
approved these changes
Jan 16, 2025
joshlacey
requested changes
Jan 16, 2025
| import { SharedFilter } from '../types/SharedFilter' | ||
| import _ from 'lodash' | ||
|
|
||
| export const updateChildFilters = (newSharedFilters: SharedFilter[], data: Record<string, any>): SharedFilter[] => { |
There was a problem hiding this comment.
Can you add logic to this function to only run if the filter is a data filter? api filters handle parent relationships differently
There was a problem hiding this comment.
Added logic to filter out all data filters
joshlacey
reviewed
Jan 21, 2025
| } | ||
| }) | ||
|
|
||
| return [...updatedFilters, ...urlFilters] |
There was a problem hiding this comment.
Won't this reorder sharedFilter indexes? They should stay in the same place as the dashboardFilter visualizations are referencing those indexes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Replace With Ticket Number]
Testing Steps
Set Up Filters in the Dashboard:
Create at least two filters with "Data" as the filter type.
Configure one as a Parent Filter and the other as a Child Filter (link the child to the parent using the Parents field).
Test Parent-Child Logic:
Select a value in the Parent Filter (e.g., Electronics).
Verify that the Child Filter updates to display only values related to the selected parent value (e.g., Sony, Samsung).
Self Review
Screenshots (if applicable)
Additional Notes