Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submissions/shared SonarCloud scans #15662

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Add submissions/shared SonarCloud scans #15662

merged 10 commits into from
Aug 27, 2024

Conversation

snesm
Copy link
Collaborator

@snesm snesm commented Aug 21, 2024

This PR adds a build action for /submissions and add /shared and /submissions to sonarcloud testing.

Note that /submissions does not have coverage statistics which may skew results.

If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.

Test Steps:

  1. Include steps to test these changes

Changes

  • Include a comprehensive list of changes in this PR
  • (For web UI changes) Include screenshots/video of changes

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

Copy link

github-actions bot commented Aug 21, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Aug 21, 2024

Test Results

1 209 tests  ±0   1 205 ✅ ±0   6m 25s ⏱️ -2s
  158 suites ±0       4 💤 ±0 
  158 files   ±0       0 ❌ ±0 

Results for commit 80d918b. ± Comparison against base commit 3be35cf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 21, 2024

Integration Test Results

 63 files   63 suites   29m 26s ⏱️
436 tests 427 ✅ 9 💤 0 ❌
439 runs  430 ✅ 9 💤 0 ❌

Results for commit 80d918b.

♻️ This comment has been updated with latest results.

@snesm
Copy link
Collaborator Author

snesm commented Aug 21, 2024

requires build action/workflow for /submissions and /shared to generate supporting files for SonarCloud

Copy link

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

Copy link

⚠️ Broken Links ⚠️

https://www.cdph.ca.gov/Programs/CID/DCDC/Pages/CalREDIE.aspx

Error: timeout of 10000ms exceeded


Copy link

sonarcloud bot commented Aug 22, 2024

@snesm snesm marked this pull request as ready for review August 26, 2024 16:26
@snesm snesm requested a review from a team as a code owner August 26, 2024 16:26
@snesm snesm merged commit 27e0ee2 into master Aug 27, 2024
16 checks passed
@snesm snesm deleted the snesm/sonarSubmissions branch August 27, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonarCloud scan /shared and /submissions
2 participants