Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engagement/jessica/15405 deidentification enrichment #15669

Merged

Conversation

JessicaWNava
Copy link
Collaborator

@JessicaWNava JessicaWNava commented Aug 22, 2024

This PR adds a piiremoval command to the CLI that takes a file and removes its pii using a combination of code and transformas then outputs the result to the specified output file.

Test Steps:

  1. Give it a file with PII and make sure it is removed in the output

Changes

  • New PII removal CLI command

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

@JessicaWNava JessicaWNava requested a review from a team as a code owner August 22, 2024 18:53
Copy link

github-actions bot commented Aug 22, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Aug 22, 2024

Test Results

1 209 tests  ±0   1 205 ✅ ±0   6m 18s ⏱️ -22s
  158 suites ±0       4 💤 ±0 
  158 files   ±0       0 ❌ ±0 

Results for commit 3978e72. ± Comparison against base commit a65a512.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 22, 2024

Integration Test Results

 63 files  ±0   63 suites  ±0   29m 12s ⏱️ +25s
437 tests ±0  428 ✅ ±0  9 💤 ±0  0 ❌ ±0 
440 runs  ±0  431 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 3978e72. ± Comparison against base commit a65a512.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@victor-chaparro victor-chaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
3.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@JessicaWNava JessicaWNava merged commit c2577bc into master Aug 29, 2024
21 of 22 checks passed
@JessicaWNava JessicaWNava deleted the engagement/jessica/15405-deidentification-enrichment branch August 29, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants