Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create E2E tests for api page #15709

Merged

Conversation

jpandersen87
Copy link
Collaborator

@jpandersen87 jpandersen87 commented Aug 26, 2024

Fixes #14782

This PR adds E2E tests for the api page.

@jpandersen87 jpandersen87 added the frontend Work Type label to flag work related to the front-end websites label Aug 26, 2024
@jpandersen87 jpandersen87 self-assigned this Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Collaborator

@penny-lischer penny-lischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpandersen87 jpandersen87 changed the title Create E2E tests for developer resources index and api pages Create E2E tests for api page Aug 26, 2024
Copy link
Collaborator

@penny-lischer penny-lischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@etanb etanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be using the new .testHeader() and .testFooter() methods available in BasePage instead of repeating the logic for header / footer in these e2e tests.

We also have logic for .testSidenav(): https://github.com/CDCgov/prime-reportstream/blob/master/frontend-react/e2e/pages/BasePage.ts#L150-L159

@jpandersen87
Copy link
Collaborator Author

we should be using the new .testHeader() and .testFooter() methods available in BasePage instead of repeating the logic for header / footer in these e2e tests.

We also have logic for .testSidenav(): https://github.com/CDCgov/prime-reportstream/blob/master/frontend-react/e2e/pages/BasePage.ts#L150-L159

fixed

@jpandersen87 jpandersen87 enabled auto-merge (squash) August 29, 2024 18:25
Copy link

sonarcloud bot commented Aug 29, 2024

Copy link

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

@jpandersen87 jpandersen87 merged commit eee3ae9 into master Aug 29, 2024
27 of 30 checks passed
@jpandersen87 jpandersen87 deleted the experience/14782-Create-E2E-tests-for-the-API-Guide-Page branch August 29, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Work Type label to flag work related to the front-end websites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create E2E tests for the API Guide Page
3 participants