Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create E2E tests for the API Getting Started, documentation pages #15711

Merged
merged 9 commits into from
Aug 29, 2024
Merged

Create E2E tests for the API Getting Started, documentation pages #15711

merged 9 commits into from
Aug 29, 2024

Conversation

jpandersen87
Copy link
Collaborator

@jpandersen87 jpandersen87 commented Aug 26, 2024 •
edited
Loading

Fixes #14789 #14790 #14792 #14793

This PR adds E2E tests for the api getting started page, and the documentation pages.

@jpandersen87 jpandersen87 self-assigned this Aug 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@jpandersen87 jpandersen87 added the frontend Work Type label to flag work related to the front-end websites label Aug 26, 2024
etanb
etanb requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@etanb etanb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be using the new .testHeader() and .testFooter() methods available in BasePage instead of repeating the logic for header / footer in these e2e tests.

@jpandersen87
Copy link
Collaborator Author

we should be using the new .testHeader() and .testFooter() methods available in BasePage instead of repeating the logic for header / footer in these e2e tests.

fixed

penny-lischer
penny-lischer approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@penny-lischer penny-lischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpandersen87 jpandersen87 enabled auto-merge (squash) August 29, 2024 17:37
@github-actions GitHub Actions
Copy link

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jpandersen87 jpandersen87 merged commit 487d454 into master Aug 29, 2024
28 of 30 checks passed
@jpandersen87 jpandersen87 deleted the experience/14789-Create-E2E-tests-for-the-API-Getting-Started-Page branch August 29, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etanb etanb etanb approved these changes

@penny-lischer penny-lischer penny-lischer approved these changes

@victor-chaparro victor-chaparro Awaiting requested review from victor-chaparro

Assignees

@jpandersen87 jpandersen87

Labels
frontend Work Type label to flag work related to the front-end websites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create E2E tests for the API Getting Started Page
3 participants
@jpandersen87 @etanb @penny-lischer