Fix E2E test Filedownload issue #15730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etanb
added
the
experience
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
2 tasks
…:CDCgov/prime-reportstream into experience/15612/file-download-e2e-issue
frontend-react/e2e/helpers/utils.ts
Outdated
| @@ -139,3 +139,18 @@ export function toDateWithTime(date: string, time?: string) { | |||
| } | |||
| return toDateTime; | |||
| } | |||
|
|
|||
| export function removeTimestamp(filename: string) { | |||
There was a problem hiding this comment.
maybe rename function to removeDateTime? or maybe keep the date and just remove the last 10 chars from the filename?
There was a problem hiding this comment.
i'll rename it. i wanted to keep the extension (in this case .hl7) intact in case things change + keep the specificity of filetype.
jpandersen87
approved these changes
Aug 30, 2024
|
Branch deployed to Chromatic 🚀.
View via: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our issue with File Downloading in our Daily Data page as well as skipping the Search feature for now.
Fixes #15612