-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix E2E test Filedownload issue #15730
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
…:CDCgov/prime-reportstream into experience/15612/file-download-e2e-issue
frontend-react/e2e/helpers/utils.ts
Outdated
@@ -139,3 +139,18 @@ export function toDateWithTime(date: string, time?: string) { | |||
} | |||
return toDateTime; | |||
} | |||
|
|||
export function removeTimestamp(filename: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe rename function to removeDateTime
? or maybe keep the date and just remove the last 10 chars from the filename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll rename it. i wanted to keep the extension (in this case .hl7
) intact in case things change + keep the specificity of filetype.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Branch deployed to Chromatic 🚀.
View via: |
Quality Gate passedIssues Measures |
This PR fixes our issue with File Downloading in our Daily Data page as well as skipping the Search feature for now.
Fixes #15612