Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug while truncating OBX-23-1. #15770

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

victor-chaparro
Copy link
Collaborator

This PR fixes an issue CA identified when OBX-23-1 is longer than 50 characters and the NPI was being truncated. The facility name needs to be truncated and not the NPI.

@victor-chaparro victor-chaparro requested a review from a team as a code owner September 4, 2024 15:21
Copy link

github-actions bot commented Sep 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Sep 4, 2024

Test Results

1 209 tests  ±0   1 205 ✅ ±0   6m 29s ⏱️ +13s
  158 suites ±0       4 💤 ±0 
  158 files   ±0       0 ❌ ±0 

Results for commit 2e6396b. ± Comparison against base commit 9e4a97c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 4, 2024

Integration Test Results

 63 files  ±0   63 suites  ±0   29m 18s ⏱️ -12s
437 tests ±0  428 ✅ ±0  9 💤 ±0  0 ❌ ±0 
440 runs  ±0  431 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 2e6396b. ± Comparison against base commit 9e4a97c.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Sep 4, 2024

@victor-chaparro victor-chaparro merged commit 11474db into master Sep 4, 2024
23 checks passed
@victor-chaparro victor-chaparro deleted the engagement/ca-truncation-bug branch September 4, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants