Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16084: add support for submitting reports via blob trigger #16237

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

mkalish
Copy link
Collaborator

@mkalish mkalish commented Oct 16, 2024

This PR adds the ability to process reports via SFTP upload

Test Steps:

  1. Open azure storage explorer
  2. Create a new blob container sftp-submissions
  3. In the new container, create the directory structure ignore/ignore-full-elr
  4. Add an HL7 file to the new directory
  5. Confirm that the file is processed by the pipeline

Changes

  • New blob trigger that handles files getting added to a storage container
  • Steps for setting up SFTP ingestion

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

To Be Done

Specific Security-related subjects a reviewer should pay specific attention to

Copy link

github-actions bot commented Oct 16, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Oct 16, 2024

Test Results

1 249 tests  +3   1 245 ✅ +3   8m 9s ⏱️ +43s
  163 suites +1       4 💤 ±0 
  163 files   +1       0 ❌ ±0 

Results for commit 1af8cf8. ± Comparison against base commit 37c2524.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 16, 2024

Integration Test Results

 53 files   53 suites   28m 14s ⏱️
411 tests 402 ✅ 9 💤 0 ❌
414 runs  405 ✅ 9 💤 0 ❌

Results for commit 1af8cf8.

♻️ This comment has been updated with latest results.

@mkalish mkalish added the platform Platform Team label Oct 16, 2024
@mkalish mkalish marked this pull request as ready for review October 16, 2024 17:45
@mkalish mkalish requested a review from a team as a code owner October 16, 2024 17:45
@jalbinson
Copy link
Collaborator

confirmed that dropping an hl7 file in the blobstore with the correct directory structure triggers the function correctly.

Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
73.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@mkalish mkalish merged commit d69cfb5 into master Oct 22, 2024
21 of 22 checks passed
@mkalish mkalish deleted the platform/kalish/16084-sftp-ingestion-for-reports branch October 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants