-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unifying local and in memory azure event service classes into one #16257
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Integration Test Results 53 files 53 suites 27m 31s ⏱️ Results for commit 8eef145. ♻️ This comment has been updated with latest results. |
5362a76
to
b76a964
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit and integration tests pass for me - changes look ok.
couple of quick things about the PR itself for future reference
- in the "steps to replicate" section you instruct to use the "build" target. The team has had prior conversations about this and according to @mkalish we shouldn't be using the "build" target but instead the "package" target. NBD and this is partly why we were having dialogue today about build file and documenting what the right thing to do is with respect to build tasks.
- there's a doc somewhere that lays out how branches should be named. @MichaelEsuruoso @arnejduranovic or @mkalish will know where it is. My understanding is branches should be named as such
platform/kalish/16084-sftp-ingestion-for-reports
- under "changes" you left the default text there. Please in future either remove that section or populate it with ticket-specific changes.
🍻 and nice job!
Quality Gate passedIssues Measures |
This PR unifies local and in memory azure event service classes into one
Test Steps:
Changes
Checklist
Testing
./prime test
or./gradlew testSmoke
against local Docker ReportStream container?npm run lint:write
?Linked Issues