unifying local and in memory azure event service classes into one #16257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
1 task
Integration Test Results 53 files 53 suites 27m 31s ⏱️ Results for commit 8eef145. ♻️ This comment has been updated with latest results. |
kant777
force-pushed
the
refactor/azure_event_service
branch
from
5362a76
to
b76a964
Compare
david-navapbc
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
unit and integration tests pass for me - changes look ok.
couple of quick things about the PR itself for future reference
- in the "steps to replicate" section you instruct to use the "build" target. The team has had prior conversations about this and according to @mkalish we shouldn't be using the "build" target but instead the "package" target. NBD and this is partly why we were having dialogue today about build file and documenting what the right thing to do is with respect to build tasks.
- there's a doc somewhere that lays out how branches should be named. @MichaelEsuruoso @arnejduranovic or @mkalish will know where it is. My understanding is branches should be named as such
platform/kalish/16084-sftp-ingestion-for-reports - under "changes" you left the default text there. Please in future either remove that section or populate it with ticket-specific changes.
🍻 and nice job!
arnejduranovic
approved these changes
Oct 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies local and in memory azure event service classes into one
Test Steps:
Changes
Checklist
Testing
./prime testor./gradlew testSmokeagainst local Docker ReportStream container?npm run lint:write?Linked Issues