Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed channel mixup and removed remnants of utility function #186

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

kyleoconnell
Copy link
Collaborator

Description

did more work to fix the channel mismatch, seems to be fixed. Now the reads_ch is meta.id, fasta, fastq1, fastq2 so I also modified the annotation modules to accomdate this longer tuple, although it doesn't change the process in practice.

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • [] Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • [] Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • [] Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • [] Did you check for sensitive data, and remove any?
  • [] If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:

@kyleoconnell kyleoconnell self-assigned this Mar 15, 2024
@jessicarowell jessicarowell requested review from jessicarowell and removed request for RamiyapriyaS March 15, 2024 14:20
@jessicarowell jessicarowell merged commit 4dc7bae into dev Mar 15, 2024
1 check failed
@jessicarowell jessicarowell deleted the seqera_patch_kao branch April 12, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants