Skip to content

Commit

Permalink
20230625 smallfix (#145)
Browse files Browse the repository at this point in the history
* - Fix System Requirements
- bump version
- small doc update

* update submission

* Fixes for CRAN upload

* bibEntry --> bibentry

* fix citation

---------

Co-authored-by: Zachary Charlop-Powers <zcpowers@Zacharys-MacBook-Air.local>
  • Loading branch information
zachcp and Zachary Charlop-Powers authored Jul 7, 2023
1 parent bad2209 commit 400d400
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 41 deletions.
5 changes: 3 additions & 2 deletions rcdk/DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: rcdk
Version: 3.8.0
Date: 2023-06-11
Version: 3.8.1
Date: 2023-06-25
Title: Interface to the 'CDK' Libraries
Authors@R: c(person('Rajarshi', 'Guha', role=c('aut',"cph"), email='rajarshi.guha@gmail.com'),
person('Zachary', 'Charlop-Powers', role=c('cre'), email='zach.charlop.powers@gmail.com'),
Expand All @@ -23,6 +23,7 @@ Suggests:
License: LGPL
LazyLoad: yes
LazyData: true
SystemRequirements: Java (>= 8)
Description: Allows the user to access functionality in the
'CDK', a Java framework for chemoinformatics. This allows the user to load
molecules, evaluate fingerprints, calculate molecular descriptors and so on.
Expand Down
2 changes: 2 additions & 0 deletions rcdk/NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# rcdk 3.8.0

* Change DESCRIPTION in accordance with CRAN rules about JDKs
* Fix System Requirements line


# rcdk 3.7.0

Expand Down
2 changes: 1 addition & 1 deletion rcdk/R/formula.R
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#' mass and window accuracy
#' @author Miguel Rojas-Cherto (\email{miguelrojasch@@yahoo.es})
#' @references A parallel effort to expand the Chemistry Development
#' Kit: \url{http://cdk.sourceforge.net}
#' Kit: \url{https://cdk.github.io/}
#' @seealso
#' \code{\link{get.formula}}
#' \code{\link{set.charge.formula}}
Expand Down
37 changes: 3 additions & 34 deletions rcdk/cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,36 +1,5 @@
## General Comments

- This is a resubmission of rcdk-3.7. I have fixed a few NOTES relates to R code quality.
- There is an ERROR on the cloud system related to a difference between the primary dependency of this library, rcdklibs.
- This package should be co-evaluated with rcdklibs



## Submission
rCDK v 3.7.0

## Test environments
* local OS X install, R 4.2
* win-builder (release)

## R CMD check results

0 errors | 0 warnings | 0 note


## Reverse dependencies

Using the latest rcdklibs (2.8) and this version of rcdk (3.7) I obtained the following
results.

---

```
✔ DeepPINCS 1.4.0 ── E: 0 | W: 0 | N: 2
✔ Rcpi 1.32.2 ── E: 0 | W: 0 | N: 2
✔ RMassBank 3.6.1 ── E: 0 | W: 4 | N: 4
✔ RxnSim 1.0.3 ── E: 0 | W: 0 | N: 0
✔ webchem 1.1.3 ── E: 0 | W: 0 | N: 0
```


- submission of rcdk 3.8.1
- fix to the SystemRequirements Field
- update CITATION file
5 changes: 3 additions & 2 deletions rcdk/inst/CITATION
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
citHeader("To cite rcdk in publications use:")
citEntry(entry = "article",
author = personList(person(given="Rajarshi",family="Guha", email="rajarshi.guha@gmail.com")),
bibentry(
bibtype = "article",
author = c(person(given="Rajarshi",family="Guha", email="rajarshi.guha@gmail.com")),
journal = "Journal of Statistical Software",
number = 6,
title = "Chemical Informatics Functionality in R",
Expand Down
2 changes: 1 addition & 1 deletion rcdk/man/cdkFormula-class.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion rcdk/man/get.depictor.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 400d400

Please sign in to comment.