Skip to content

Commit

Permalink
Preparing for a release v0.3 (#120)
Browse files Browse the repository at this point in the history
* Version Bump

* Make pynfft as optional install

* Update the circleci testbench

* Fix Readme

* Update the readme

* Release v0.3 change

* Loosen the install for scikit-image

* Update readme to conda

* Slacken the test_scripts

* Circleci pull latest modopt

* Circleci pull latest modopt

Co-authored-by: chaithyagr <chaithyagr@gitlab.com>
  • Loading branch information
chaithyagr and chaithyagr authored Apr 22, 2021
1 parent 90c9d12 commit cf43910
Show file tree
Hide file tree
Showing 6 changed files with 37 additions and 14 deletions.
3 changes: 2 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
. venv/bin/activate
pip install --upgrade pip
pip install --upgrade git+https://github.com/cea-cosmic/pysap
pip install -r doc/requirements.txt
pip install --upgrade -r doc/requirements.txt
pip list > doc/state.txt
- save_cache:
paths:
Expand All @@ -44,6 +44,7 @@ jobs:
pip install --upgrade pip
pip install Cython
pip install -e .
pip install pynfft2
TESTFILES=$(circleci tests glob examples/*.py | circleci tests split --split-by=timings)
echo ${TESTFILES}
python3 -m unittest ${TESTFILES}
Expand Down
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ install:
- pip install git+https://github.com/CEA-COSMIC/pysap.git
- export PYTHONPATH=$TRAVIS_BUILD_DIR/install:$PYTHONPATH
- pip install -b $TRAVIS_BUILD_DIR/build -t $TRAVIS_BUILD_DIR/install --no-clean --upgrade .
- pip install pynfft2

script:
- python setup.py test
Expand Down
33 changes: 27 additions & 6 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,42 @@ pySAP-mri
Python Sparse data Analysis Package external MRI plugin.

This work is made available by a community of people, amoung which the
CEA Neurospin UNATI and CEA CosmoStat laboratories, in particular A. Grigis,
J.-L. Starck, P. Ciuciu, and S. Farrens.
CEA Neurospin UNATI and CEA CosmoStat laboratories. This plugin was developed by
A. Grigis, J.-L. Starck, P. Ciuciu, and S. Farrens. Currently, it is being handled by
Chaithya G R, Z. Ramzi and S. Farrens.

Installation instructions
=========================

Install python-pySAP using `pip install python-pySAP`. Later install pysap-mri by calling setup.py
Note: If you want to use undecimated wavelet transform, please point the `$PATH` environment variable to
pysap external binary directory:
Install python-pySAP using:

`export PATH=$PATH:/path-to-pysap/build/temp.linux-x86_64-<PYTHON_VERSION>/extern/bin/`
``pip install python-pysap``

This will install pysap-mri plugin too. However if you want to update to a more
later version, please use:

``pip install --upgrade pysap-mri``

Special Installations
=====================

`pyNFFT <https://github.com/pyNFFT/pyNFFT/>`_
--------------------------------------------

For using Non-Cartesian FFT, please install pyNFFT by:

Linux:
``````

``sudo apt install libnfft3-dev``

``pip install pynfft2``

Mac:
````

``conda install -c conda-forge pynfft``

`gpuNUFFT <https://www.opensourceimaging.org/project/gpunufft/>`_
---------------------------------------------------------------

Expand Down
4 changes: 2 additions & 2 deletions mri/info.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

# Module current version
version_major = 0
version_minor = 2
version_micro = 2
version_minor = 3
version_micro = 0

# Expected by setup.py: string of form "X.Y.Z"
__version__ = "{0}.{1}.{2}".format(version_major, version_minor, version_micro)
Expand Down
3 changes: 2 additions & 1 deletion mri/tests/test_scripts.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ def test_gridsearch_single_channel(self):
np.testing.assert_equal(best_idx, 0)
np.testing.assert_allclose(
raw_results[best_idx][0],
image
image,
atol=1e-7,
)


Expand Down
7 changes: 3 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,16 @@
classifiers="CLASSIFIERS",
author=AUTHOR,
author_email="XXX",
version="0.2.2",
version="0.3.0",
url="https://github.com/CEA-COSMIC/pysap-mri",
packages=find_packages(),
setup_requires=setup_requires,
install_requires=[
"scikit-learn>=0.19.1",
"progressbar2>=3.34.3",
"joblib",
"joblib>=1.0.0",
"scipy>=1.3.0",
"pynfft2>=1.3.3",
"scikit-image",
"scikit-image>=0.17.0",
],
tests_require=['pytest>=5.0.1', 'pytest-cov>=2.7.1', 'pytest-pep8', 'pytest-runner'],
platforms="OS Independent"
Expand Down

0 comments on commit cf43910

Please sign in to comment.