Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action to lint PR commits #74

Merged
merged 1 commit into from
May 8, 2020

Conversation

ramonhpr
Copy link
Contributor

@ramonhpr ramonhpr commented May 7, 2020

Describe what this PR introduces: (if necessary, link currently open issues with special keywords)

What kind of change does this PR introduce? (check at least one)

  • Bug fix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:
    Add a github action to lint each Pull Request to master.

Does this PR introduce any breaking changes? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • Related issues are referenced in the PR (Add CI/CD pipeline #26)
  • All tests are passing
  • New/updated tests are included

Testing environment:

  • Operating System/Platform: 5.4.35-1-MANJARO
  • Go version: 1.14.2

If you have relevant logs, error output and etc, please attach them.

Other information:

@ramonhpr ramonhpr requested a review from netoax May 7, 2020 23:07
@ramonhpr ramonhpr requested review from lcbm and vitbaq as code owners May 7, 2020 23:07
@ramonhpr ramonhpr self-assigned this May 7, 2020
@ramonhpr ramonhpr force-pushed the devel_action_commitlint branch from d9193d8 to ea395d7 Compare May 7, 2020 23:09
Copy link
Collaborator

@lcbm lcbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, pt. 2. 💯

@@ -0,0 +1,45 @@
module.exports = {
parserPreset: '@commitlint/config-conventional',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@netoax netoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@netoax netoax merged commit d16888c into CESARBR:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants