Merge pull request #28 from CESNET/doxygen-ci-fix

github-action - doxygen now reports warning as errors
CESNET · Oct 9, 2024 · 89efb38 · 89efb38
2 parents 88ae5a4 + a5880ca
commit 89efb38
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -51,7 +51,7 @@ jobs:
         dnf config-manager --set-enabled ol9_codeready_builder
         dnf install -y doxygen
     - name: make doxygen
-      run: make doxygen
+      run: make doxygen CMAKE_ARGS="-DDOXYGEN_WARN_AS_ERROR=YES"
     - name: upload Doxygen artifact
       uses: actions/upload-artifact@v4
       with:

diff --git a/include/telemetry/holder.hpp b/include/telemetry/holder.hpp
@@ -38,7 +38,17 @@ class Holder {
 
 	Holder(const Holder& other) = delete;
 	Holder& operator=(const Holder& other) = delete;
-	Holder(Holder&& other) = default;
+	/**
+	 * @brief Move constructor
+	 * @param other Other holder
+	 */
+	Holder(Holder&& other) = delete;
+
+	/**
+	 * @brief Move assignment
+	 * @param other Other holder
+	 * @return Reference to this holder
+	 */
 	Holder& operator=(Holder&& other) = default;
 
 	/**