Merge pull request #7902 from sloriot/CGALLab-fix_menu_filtering

Copy the buffer to allow modifications during iteration
CGAL · Dec 1, 2023 · 29c90e5 · 29c90e5
2 parents 120547b + a8c58f8
commit 29c90e5
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Polyhedron/demo/Polyhedron/MainWindow.cpp b/Polyhedron/demo/Polyhedron/MainWindow.cpp
@@ -376,7 +376,8 @@ void filterMenuOperations(QMenu* menu, QString filter, bool keep_from_here)
     buffer.append(action);
 
   while(!buffer.isEmpty()){
-    for(QAction* action : buffer) {
+    QList<QAction*> buffer_copy=buffer; // make a copy as we modify buffer in the loop
+    for(QAction* action : buffer_copy) {
       if(QMenu* submenu = action->menu())
       {
         bool keep = true;