Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Compiler and OS Info to the TestSuite description table #8188

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Add Compiler and OS Info to the TestSuite description table #8188

merged 4 commits into from
Oct 23, 2024

Conversation

SaillantNicolas
Copy link
Member

@SaillantNicolas SaillantNicolas commented May 6, 2024 •
edited
Loading

Summary of Changes

Add Compiler and OS Information to TestSuite Platform Description Table
This PR is linked with those PRs:

The version of this Pull Request can be reviewed at this link

Release Management

@SaillantNicolas SaillantNicolas mentioned this pull request May 6, 2024
Merged
@lrineau lrineau linked an issue May 7, 2024 that may be closed by this pull request
TestSuite: Refactor 'OS and Compiler' Section #8167
Closed
@lrineau
Copy link
Member

lrineau commented May 13, 2024

I have the impression this pull-request would break the compatibility with the release branches. Am I right?

@lrineau lrineau added the Not yet approved The feature or pull-request has not yet been approved. label May 21, 2024
@lrineau
Copy link
Member

lrineau commented Aug 22, 2024

I have the impression this pull-request would break the compatibility with the release branches. Am I right?

Actually no. It should be OK. I will test it.

@lrineau lrineau removed the Not yet approved The feature or pull-request has not yet been approved. label Sep 11, 2024
@lrineau
Copy link
Member

lrineau commented Sep 11, 2024 •
edited
Loading

I have the impression this pull-request would break the compatibility with the release branches. Am I right?

Actually no. It should be OK. I will test it.

I have tested on the actual testsuite, without the patch in Installation/CMakeLists.txt. And the result is:

Screenshot_20240911_160744

@lrineau
Copy link
Member

lrineau commented Sep 11, 2024 •
edited
Loading

So, it is ready to be tested in integration and master. Maybe it should be backported to release branches.

@lrineau lrineau force-pushed the update_cmake_vars_for_arch_compiler_info-GF branch from 7b49b4c to e72157c Compare September 25, 2024 17:58
@lrineau
Refactor indentation in a few developer scripts (remove tabs)
9b4c27d 
I have ignored the scripts that I do not use.

NOTE: `Scripts/developer_scripts/create_internal_release` seems not
used anymore, but I have updated it anyway.`
@lrineau lrineau force-pushed the update_cmake_vars_for_arch_compiler_info-GF branch from e72157c to 9b4c27d Compare September 25, 2024 18:00
@sloriot sloriot added this to the 6.1-beta milestone Oct 10, 2024
@sloriot
Copy link
Member

sloriot commented Oct 14, 2024

@lrineau what do you want to do with this branch?

@lrineau
Copy link
Member

lrineau commented Oct 14, 2024

@lrineau what do you want to do with this branch?

I am waiting for you to tell us it is Tested . It will then be merged in master.

@sloriot
Copy link
Member

sloriot commented Oct 14, 2024 •
edited
Loading

It does not induce any issue in the testsuite but I don't know if it means it's tested :)

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Oct 21, 2024
@sloriot sloriot merged commit 2a57275 into CGAL:master Oct 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrineau lrineau lrineau approved these changes

Assignees

@sloriot sloriot

@lrineau lrineau

Labels
Enhancement Feature request Infrastructure rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' Tested Testsuite
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.

TestSuite: Refactor 'OS and Compiler' Section
3 participants
@SaillantNicolas @lrineau @sloriot