-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TESTSUITE: Extract cmake logs in testresults. #8235
TESTSUITE: Extract cmake logs in testresults. #8235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems import io
is not used.
Actually, the linter pylint reports a lot of warning about this code.
@afabri @MaelRL @sloriot What do you think about the improvements? See here for an example: https://cgal.geometryfactory.com/~nsaillant/CmakeLogsTestsuite/TestReport_cgal_tester_Fedora |
LGTM |
looks good to me. |
And Linux dockers all give an error:
See https://cgal.geometryfactory.com/CGAL/testsuite/results-6.0-Ic-261.shtml |
There are some strange lines in https://cgal.geometryfactory.com/CGAL/testsuite/results-6.0-Ic-316.shtml. |
@sloriot Ready to be re-tested. |
Again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, now.
With Nicolas we have found and solved the issue on magritte
.
It was:
set(WITH_tests ON CACHE BOOL "")
in the "initial cache" for the platform.
Summary of Changes
This PR moves and adds some CMake logs to the test results.
The changes of this Pull Request can be viewed here
Release Management