Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTSUITE: Extract cmake logs in testresults. #8235

Merged

Conversation

SaillantNicolas
Copy link
Member

@SaillantNicolas SaillantNicolas commented May 29, 2024

Summary of Changes

This PR moves and adds some CMake logs to the test results.
The changes of this Pull Request can be viewed here

Release Management

Copy link
Member

@lrineau lrineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems import io is not used.

Actually, the linter pylint reports a lot of warning about this code.

Testsuite/test/post_process_ctest_results.py Outdated Show resolved Hide resolved
@lrineau
Copy link
Member

lrineau commented Jun 3, 2024

This PR moves and adds some CMake logs to the test results. The changes of this Pull Request can be viewed here

@afabri @MaelRL @sloriot What do you think about the improvements? See here for an example: https://cgal.geometryfactory.com/~nsaillant/CmakeLogsTestsuite/TestReport_cgal_tester_Fedora

@lrineau lrineau self-assigned this Jun 3, 2024
@sloriot
Copy link
Member

sloriot commented Jun 3, 2024

This PR moves and adds some CMake logs to the test results. The changes of this Pull Request can be viewed here

@afabri @MaelRL @sloriot What do you think about the improvements? See here for an example: https://cgal.geometryfactory.com/~nsaillant/CmakeLogsTestsuite/TestReport_cgal_tester_Fedora

LGTM

@afabri
Copy link
Member

afabri commented Jun 3, 2024

looks good to me.

@lrineau lrineau marked this pull request as ready for review June 4, 2024 09:52
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 4, 2024
@lrineau lrineau added this to the 6.0-beta milestone Jun 4, 2024
@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' Under Testing and removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Jun 4, 2024
@lrineau
Copy link
Member

lrineau commented Jun 5, 2024

@lrineau
Copy link
Member

lrineau commented Jun 6, 2024

And Linux dockers all give an error:

Traceback (most recent call last):
  File "/mnt/testsuite/test/post_process_ctest_results.py", line 56, in <module>
    for myline in input_report_file:
ValueError: I/O operation on closed file.

See https://cgal.geometryfactory.com/CGAL/testsuite/results-6.0-Ic-261.shtml

@lrineau lrineau added Tests failing and removed Under Testing rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Jun 6, 2024
@lrineau lrineau self-requested a review June 11, 2024 12:36
@lrineau lrineau modified the milestones: 6.0-beta, 6.0 Jun 11, 2024
@lrineau lrineau assigned sloriot and unassigned lrineau Aug 22, 2024
@sloriot
Copy link
Member

sloriot commented Sep 2, 2024

There are some strange lines in https://cgal.geometryfactory.com/CGAL/testsuite/results-6.0-Ic-316.shtml.

image

@lrineau
Copy link
Member

lrineau commented Sep 3, 2024

@sloriot Ready to be re-tested.

@lrineau
Copy link
Member

lrineau commented Sep 11, 2024

@sloriot Ready to be re-tested.

Again

Copy link
Member

@lrineau lrineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, now.

With Nicolas we have found and solved the issue on magritte.

It was:

set(WITH_tests ON CACHE BOOL "")

in the "initial cache" for the platform.

@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' and removed Under Testing rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Sep 25, 2024
@lrineau lrineau merged commit 50219fc into CGAL:master Sep 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testsuite: copy-paste relevant parts of the cmake log, into each test results (foobar.gz)
4 participants