Updating tests to reflect the new output format #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
|
I would rather extract the |
Signed-off-by: Matthew Johnson <matjoh@microsoft.com>
I've taken a stab at this, let me know what you think. |
Signed-off-by: Matthew Johnson <matjoh@microsoft.com>
davidchisnall
approved these changes
Jun 14, 2024
|
Looks like the snmalloc clone is broken? |
Signed-off-by: Matthew Johnson <matjoh@microsoft.com>
|
I've updated it to the 0.4.0 release of Rego. The snmalloc commit issue was upstream in Trieste, and appears to be resolved for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the upgrade of rego-cpp to Rego v0.65.0 the output of the tool is now valid JSON. The PR updates the commit tag and edits the tests so that the grep matches again.