Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reverse sentry pseudolocality #82

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Remove reverse sentry pseudolocality #82

merged 1 commit into from
Nov 14, 2024

Conversation

nwf
Copy link
Member

@nwf nwf commented Nov 8, 2024

It was not fully baked on the way in and probably merits a bit more thought before we commit to it.

@nwf
Remove reverse sentry pseudolocality
d3fedbc 
It was not fully baked on the way in and probably merits a bit more
thought before we commit to it.
davidchisnall
davidchisnall approved these changes Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@davidchisnall davidchisnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a small amount of discussion about why we didn’t do this for 1.0, but that can be a later PR.

@nwf nwf merged commit 789dd7e into main Nov 14, 2024
2 checks passed
@nwf nwf deleted the 202411-rsentry-no-pseudolocality branch November 14, 2024 20:15
This was referenced Nov 14, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidchisnall davidchisnall davidchisnall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwf @davidchisnall