-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed relaxing of cjalr sealing #86
base: main
Are you sure you want to change the base?
Conversation
54497f9
to
f3c2688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to make a similar change in CJAL
.
f3c2688
to
85e58b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine except for comments. I may slightly prefer inverting the if
so that the common cd==ra
case is handled first but it does not matter.
Lgtm. As Robert pointed out, can you fix the commentary in the JAL case |
Attempt at capturing #85 Co-authored-by: Robert Norton <robert.norton@microsoft.com>
85e58b7
to
0dd27c1
Compare
Copy-paste errors fixed, conditions flipped, and archdoc prose updated to explain the changes. |
Is there a security issue if |
I think it would be fine in that the interrupt disabling DoS attack that pushed us to add return sentries would still be mitigated (because you have to use Specifically, most code will use |
My rationale is that when
Slight hardware simplification and in line with the design principle that if you want protection of the caller, use |
Attempt at capturing #85