Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the CHERITech demo and fixes necessary for it to work #20

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

davidchisnall
Copy link
Contributor

No description provided.

char clientID[clientIDlength] = "cheriot-XXXXXXXXXXXXXX";

/**
* Turn an LED on.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment be different from the one for led_on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to be reviewing something that was removed in a later commit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you copied the files in this commit from somewhere. If so, can you point to the originals if they are in another open repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are 'copied' from my Morello machine. I'm not sure what this is asking for.

@davidchisnall davidchisnall force-pushed the demo-wip branch 2 times, most recently from e49e28c to 419af6b Compare April 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants